-
Notifications
You must be signed in to change notification settings - Fork 24
[ARCH-334] Pre-requisites for EVM support #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
connorwstein
wants to merge
9
commits into
main
Choose a base branch
from
ARCH-334-evm-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+210
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 connorwstein, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
…ainlink-common into ARCH-334-evm-support
pavel-raykov
reviewed
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See corresponding PR here smartcontractkit/chainlink-evm#270 which validates the actual use of peerKeyrings in the context of OCR (see pkg/keysv2/ocr2_keyring_test.go in particular). Since ragep2p can be used as a standalone family agnostic package, I put the peer keyring layer here instead of chainlink-evm.
Separately this introduces
KeyPath []stringtype as a flexible strategy for dealing with names/grouping names for higher level key layers like peerKeyrings, OCR keyrings, tx keys etc. You can see further demonstration of the KeyPath usage/patterns in smartcontractkit/chainlink-evm#270. The general thinking behind it is to avoid the boilerplate of replicate all the admin logic per domain specific key layer, we just have a Create/Get per key layer which return handles and those handles expose a KeyPath with can be used for the more invasive/rare admin work like deleting/exporting the keys. Open to other ideas, but the typed keypath and only providing helpers for Create/Get seemed like the simplest/flexbile thing.